Skip to content

chore: breakdown array.slt into smaller files#21658

Merged
comphead merged 3 commits intoapache:mainfrom
comphead:chore
Apr 16, 2026
Merged

chore: breakdown array.slt into smaller files#21658
comphead merged 3 commits intoapache:mainfrom
comphead:chore

Conversation

@comphead
Copy link
Copy Markdown
Contributor

@comphead comphead commented Apr 15, 2026 •
edited
Loading

Which issue does this PR close?

Rationale for this change

Summary

  • Split the monolithic array.slt (10,038 lines) into 31 focused per-function test files under test_files/array/
  • Shared table setup (692 lines) extracted into array/init_data.slt.part, shared cleanup into array/cleanup.slt.part, each test file includes both via include directives
  • Removed array.slt from TEST_PRIORITY_ENTRIES in test_file.rs since split files are small enough to not need scheduling priority

New files

File Function(s) tested
init_data.slt.part Shared table setup (included by all test files)
cleanup.slt.part Shared table teardown (included by all test files)
array_literal.slt Array literal syntax, coercion
array_index.slt array[i], array[i:j], array[i:j:k]
make_array.slt make_array / make_list
array_element.slt array_element / array_extract / list_extract
array_min_max.slt array_max, array_min
array_pop.slt array_pop_back, array_pop_front
array_slice.slt array_slice / list_slice
array_any_value.slt array_any_value / list_any_value
array_sort.slt array_sort / list_sort
array_append.slt array_append / list_append / array_push_back
array_prepend.slt array_prepend / list_prepend / array_push_front
array_repeat.slt array_repeat / list_repeat
array_concat.slt array_concat / array_cat / list_concat
array_position.slt array_position / array_positions
array_replace.slt array_replace / array_replace_n / array_replace_all
array_to_string.slt array_to_string / array_join / list_join
array_union.slt array_union / list_union
array_remove.slt array_remove / array_remove_n / array_remove_all
array_length.slt array_length / array_dims / array_ndims / array_distance
array_has.slt array_has / array_has_all / array_has_any
array_distinct.slt array_distinct / array_compact
arrays_zip.slt arrays_zip / list_zip
array_range.slt range / generate_series
array_except.slt array_except
array_operators.slt Array concat (||), containment (@>) operators
array_cast.slt Array casting, FixedSizeList, flatten
array_empty.slt empty / array_empty / list_empty
string_to_array.slt string_to_array
array_resize.slt array_resize
array_reverse.slt array_reverse + misc edge cases

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Apr 15, 2026
@comphead
Copy link
Copy Markdown
Contributor Author

comphead commented Apr 16, 2026

Thanks @martin-g for the review

@comphead comphead added this pull request to the merge queue Apr 16, 2026
Merged via the queue into apache:main with commit 9873357 Apr 16, 2026
31 checks passed
@comphead comphead deleted the chore branch April 16, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-g martin-g martin-g approved these changes

Assignees

No one assigned

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore: Break down array.slt into smaller files

2 participants

@comphead @martin-g